Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse/Bump Tmds.DBus.SourceGenerator #14548

Merged

Conversation

affederaffe
Copy link
Contributor

What does the pull request do?

Use the NuGet pacakge of Tmds.DBus.SourceGenerator again and bump Tmds.DBus.Protocol.
This pulls in the latest changes to fix #14176

What is the current behavior?

A submodule is used

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

None

Obsoletions / Deprecations

None

Fixed issues

Fixes #14176

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.1.999-cibuild0044665-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

Copy link
Member

@jmacato jmacato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmacato jmacato enabled auto-merge March 6, 2024 09:43
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.1.999-cibuild0045780-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@jmacato jmacato added this pull request to the merge queue Mar 6, 2024
Merged via the queue into AvaloniaUI:master with commit 4f844b1 Mar 6, 2024
6 checks passed
workgroupengineering added a commit to workgroupengineering/Avalonia that referenced this pull request Mar 7, 2024
PR AvaloniaUI#14548 restored using Tmds.DBus.SourceGenerator nuget package instead of submodule, but missing submodule removal.
github-merge-queue bot pushed a commit that referenced this pull request Mar 7, 2024
PR #14548 restored using Tmds.DBus.SourceGenerator nuget package instead of submodule, but missing submodule removal.
@timunie timunie added the backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch label Apr 26, 2024
@maxkatz6 maxkatz6 removed the backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants