REST API: Fix the comment author object for comments whose author info has been edited. #7707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeherve
added
[Status] Needs Review
gwwar
approved these changes
Sep 26, 2017
There was a problem hiding this comment.
Verified that comment edits are reflected when running this branch.
One of the dangers here, would be that we could attribute a comment to someone completely different, but if we were concerned with that we wouldn't allow editing of these fields for logged in users.
dereksmart
removed
the
[Status] Needs Review
kwight
added a commit
that referenced
this pull request
Sep 29, 2017
A previous change in #7707 could lead to incorrect avatars being displayed on Highlander comments made through Facebook. This fix restores the `get_avatar_url()` param to its previous `$author` value.
dereksmart
pushed a commit
that referenced
this pull request
Sep 29, 2017
A previous change in #7707 could lead to incorrect avatars being displayed on Highlander comments made through Facebook. This fix restores the `get_avatar_url()` param to its previous `$author` value.
dereksmart
pushed a commit
that referenced
this pull request
Sep 29, 2017
A previous change in #7707 could lead to incorrect avatars being displayed on Highlander comments made through Facebook. This fix restores the `get_avatar_url()` param to its previous `$author` value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wp-adminallows a user to edit a comment author's name, email, and URL. This can be done for both logged-out and logged-in users.If a comment author is logged-in when commenting, the stored comment will also have the comment author's user ID. The presence of this ID will fail this check in
get_author(), and the author object returned by an API call will reflect the user based on that ID; any edited name, email, or URL in the comments table will be bypassed.This PR seems like the simplest way to get at the edited data: if the "author" passed in is a comment row (as determined by the presence of
comment_author_email, which is required when commenting), return data from that comment. Note that this will mean losing the original commenter's user ID and associated avatar in the response, but I think this would be desirable. Otherwise, the comment author will be displayed with their edited email, for example, and an avatar associated to another (the original) email.Another approach would be to have the same data returned for all authors (get rid of the check referenced above), but override any possible edited commenter's data. However, this could change the nature of the response; it will add an (empty)
site_idtoauthor, andIDwould no longer be0in the case of logged-in and edited comment authors. This would be a more consistent shape, but the effect would be more unpredictable – so I've proposed the former for now.D7075-code