Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScanReport: Disable hiding relevant fields #40602

Merged

Conversation

dkmyta
Copy link
Contributor

@dkmyta dkmyta commented Dec 12, 2024

Fixes #
Currently you can manually hide many relevant ScanReport fields using the DataViews settings, enough so that what can remain is unclear what it refers to. Additionally, in list view the Files entry does not have title.

Proposed changes:

  • Add enableHiding: false to all relevant fields.
  • Add Type field as default in list view

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Review ScanReport storybooks and ensure
    • You cannot hide fields
    • In list view the Files entry has a title

Sorry, something went wrong.

@dkmyta dkmyta self-assigned this Dec 12, 2024
@dkmyta dkmyta marked this pull request as ready for review December 12, 2024 22:13
@dkmyta dkmyta changed the base branch from trunk to add/protect/core December 12, 2024 22:14
Copy link
Contributor

github-actions bot commented Dec 12, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/components/scan-report-field-enable-hiding branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/components/scan-report-field-enable-hiding
    
    bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/components/scan-report-field-enable-hiding
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented Dec 12, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • 🔴 Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


🔴 Action required: Please add missing changelog entries for the following projects: projects/js-packages/components

Use the Jetpack CLI tool to generate changelog entries by running the following command: jetpack changelog add.
Guidelines: /docs/writing-a-good-changelog-entry.md


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Protect plugin:

  • Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@nateweller nateweller force-pushed the update/components/scan-report-field-enable-hiding branch from ff2d2c2 to 5cf0fbf Compare December 15, 2024 03:43
@nateweller nateweller added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it and removed [Status] In Progress labels Dec 15, 2024
@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Dec 15, 2024
@nateweller nateweller force-pushed the add/protect/core branch 2 times, most recently from 2a3f2fe to aac1879 Compare December 18, 2024 20:21
@github-actions github-actions bot added [JS Package] Scan [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. labels Dec 18, 2024
@dkmyta dkmyta requested a review from nateweller December 19, 2024 23:17
@nateweller nateweller force-pushed the add/protect/core branch 2 times, most recently from aa2eac6 to 898ae2c Compare December 31, 2024 22:44
@nateweller nateweller force-pushed the update/components/scan-report-field-enable-hiding branch from ebd3d87 to dddccde Compare December 31, 2024 23:04
Copy link
Contributor

@nateweller nateweller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dkmyta dkmyta merged commit 1db1e6c into add/protect/core Jan 2, 2025
68 of 70 checks passed
@dkmyta dkmyta deleted the update/components/scan-report-field-enable-hiding branch January 2, 2025 18:46
@github-actions github-actions bot removed the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jan 2, 2025
nateweller added a commit that referenced this pull request Jan 6, 2025
* Init project branch

* Init project branch

* Disable hiding of relevant fields

* Remove custom name field handling for files, show type by default in list view

* Init project branch

---------

Co-authored-by: Nate Weller <hello@nateweller.com>
nateweller added a commit that referenced this pull request Jan 12, 2025
* Init project branch

* Init project branch

* Disable hiding of relevant fields

* Remove custom name field handling for files, show type by default in list view

* Init project branch

---------

Co-authored-by: Nate Weller <hello@nateweller.com>
nateweller added a commit that referenced this pull request Jan 14, 2025
* Init project branch

* Init project branch

* Disable hiding of relevant fields

* Remove custom name field handling for files, show type by default in list view

* Init project branch

---------

Co-authored-by: Nate Weller <hello@nateweller.com>
nateweller added a commit that referenced this pull request Jan 22, 2025
* Init project branch

* Init project branch

* Disable hiding of relevant fields

* Remove custom name field handling for files, show type by default in list view

* Init project branch

---------

Co-authored-by: Nate Weller <hello@nateweller.com>
nateweller added a commit that referenced this pull request Jan 27, 2025
* Init project branch

* Init project branch

* Disable hiding of relevant fields

* Remove custom name field handling for files, show type by default in list view

* Init project branch

---------

Co-authored-by: Nate Weller <hello@nateweller.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JS Package] Components [JS Package] Scan [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. RNA [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants