-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ScanReport: Disable hiding relevant fields #40602
ScanReport: Disable hiding relevant fields #40602
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. 🔴 Action required: Please add missing changelog entries for the following projects: Use the Jetpack CLI tool to generate changelog entries by running the following command: Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Protect plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
322819d
to
48fba20
Compare
ff2d2c2
to
5cf0fbf
Compare
projects/js-packages/components/components/scan-report/index.tsx
Outdated
Show resolved
Hide resolved
2a3f2fe
to
aac1879
Compare
aa2eac6
to
898ae2c
Compare
ebd3d87
to
dddccde
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
* Init project branch * Init project branch * Disable hiding of relevant fields * Remove custom name field handling for files, show type by default in list view * Init project branch --------- Co-authored-by: Nate Weller <hello@nateweller.com>
* Init project branch * Init project branch * Disable hiding of relevant fields * Remove custom name field handling for files, show type by default in list view * Init project branch --------- Co-authored-by: Nate Weller <hello@nateweller.com>
* Init project branch * Init project branch * Disable hiding of relevant fields * Remove custom name field handling for files, show type by default in list view * Init project branch --------- Co-authored-by: Nate Weller <hello@nateweller.com>
* Init project branch * Init project branch * Disable hiding of relevant fields * Remove custom name field handling for files, show type by default in list view * Init project branch --------- Co-authored-by: Nate Weller <hello@nateweller.com>
* Init project branch * Init project branch * Disable hiding of relevant fields * Remove custom name field handling for files, show type by default in list view * Init project branch --------- Co-authored-by: Nate Weller <hello@nateweller.com>
Fixes #
Currently you can manually hide many relevant
ScanReport
fields using theDataViews
settings, enough so that what can remain is unclear what it refers to. Additionally, in list view theFiles
entry does not have title.Proposed changes:
enableHiding: false
to all relevant fields.Type
field as default in list viewOther information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
Files
entry has a title