Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: for loop statement incrementor will be processed in correct context #2839

Merged
merged 1 commit into from
Apr 10, 2024
Merged

fix: for loop statement incrementor will be processed in correct context #2839

merged 1 commit into from
Apr 10, 2024

Conversation

HerrCai0907
Copy link
Member

Fixes: #2838
incrementor in for loop statement should be processed after executing body.

@HerrCai0907
fix: for loop statement incrementor will be processed in correct context
528a480 
Fixes: AssemblyScript#2838
incrementor in for loop statement should be processed after executing body.
@HerrCai0907 HerrCai0907 requested a review from CountBleck April 10, 2024 02:37
CountBleck
CountBleck approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@CountBleck CountBleck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as long as nothing else breaks

@HerrCai0907 HerrCai0907 merged commit 64cba2e into AssemblyScript:main Apr 10, 2024
14 checks passed
@HerrCai0907 HerrCai0907 deleted the fix/2838 branch April 10, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CountBleck CountBleck CountBleck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ERROR TS2454: Variable is used before being assigned.
2 participants
@HerrCai0907 @CountBleck