Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Expression passed to evaluateCondition asserted to be valid #2013

Merged
merged 4 commits into from
Aug 2, 2021

Conversation

romdotdog
Copy link
Contributor

getExpressionType can return Unreachable type if expression passed is invalid
fixes #1990

  • I've read the contributing guidelines
  • I've added my name and email to the NOTICE file

src/compiler.ts Outdated Show resolved Hide resolved
@MaxGraey MaxGraey changed the title Expression passed to evaluateCondition asserted to be valid fix: Expression passed to evaluateCondition asserted to be valid Jul 31, 2021
@MaxGraey MaxGraey merged commit 81c2bad into AssemblyScript:main Aug 2, 2021
@MaxGraey
Copy link
Member

MaxGraey commented Aug 2, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiler crash for instance properties without this
3 participants