Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: minor reafactoring for asc.js #2010

Merged
merged 5 commits into from
Aug 2, 2021
Merged

chore: minor reafactoring for asc.js #2010

merged 5 commits into from
Aug 2, 2021

Conversation

MaxGraey
Copy link
Member

  • I've read the contributing guidelines
  • I've added my name and email to the NOTICE file

@MaxGraey MaxGraey requested review from dcodeIO and willemneal July 27, 2021 12:17
willemneal
willemneal reviewed Jul 28, 2021
View reviewed changes
cli/asc.js Show resolved Hide resolved
willemneal
willemneal suggested changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@willemneal willemneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit and question.

cli/asc.js Outdated Show resolved Hide resolved
cli/asc.js Outdated Show resolved Hide resolved
@MaxGraey MaxGraey merged commit dd5111b into AssemblyScript:main Aug 2, 2021
@MaxGraey MaxGraey deleted the refactor branch August 2, 2021 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willemneal willemneal willemneal requested changes

@dcodeIO dcodeIO dcodeIO approved these changes

Assignees
No one assigned
Labels
enhancement tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaxGraey @dcodeIO @willemneal