Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add redeclare variable error message (#1987) #2002

Merged
merged 2 commits into from
Jul 27, 2021
Merged

fix: add redeclare variable error message (#1987) #2002

merged 2 commits into from
Jul 27, 2021

Conversation

HerrCai0907
Copy link
Member

  • add a diagnostic message: Cannot redeclare block-scoped variable '{0}', when variants scope re-declare, throw out following message instead of abort:

    ERROR TS2451: Cannot redeclare block-scoped variable 'a'

     let a = a + b;
 ~~~~~~~~~~~~~

    in assembly/index.ts(4,3)

  • add my name and email in NOTICE

  • I've read the contributing guidelines

MaxGraey
MaxGraey reviewed Jul 24, 2021
View reviewed changes
src/flow.ts Outdated Show resolved Hide resolved
MaxGraey
MaxGraey reviewed Jul 24, 2021
View reviewed changes
src/flow.ts Outdated Show resolved Hide resolved
HerrCai0907
HerrCai0907 commented Jul 24, 2021
View reviewed changes
Copy link
Member Author

@HerrCai0907 HerrCai0907 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add error message of re-declare variable

@MaxGraey
Copy link
Member

@HerrCai0907 it seems your email desn't associate with github account

@MaxGraey
Copy link
Member

You can use <77575210+HerrCai0907@users.noreply.github.com> btw

@MaxGraey MaxGraey requested a review from dcodeIO July 24, 2021 15:33
@MaxGraey MaxGraey changed the title feat: add redeclare variable error message (#1987) fix: add redeclare variable error message (#1987) Jul 24, 2021
@MaxGraey MaxGraey merged commit 935b865 into AssemblyScript:main Jul 27, 2021
@MaxGraey
Copy link
Member

Thanks!

@HerrCai0907 HerrCai0907 deleted the issue-1987 branch July 27, 2021 12:04
@MaxGraey MaxGraey mentioned this pull request Jul 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxGraey MaxGraey MaxGraey left review comments

@dcodeIO dcodeIO Awaiting requested review from dcodeIO

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HerrCai0907 @MaxGraey