Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check function's instance class is a subclass of virtual method #1985

Merged
merged 6 commits into from
Jul 23, 2021
Merged

fix: check function's instance class is a subclass of virtual method #1985

merged 6 commits into from
Jul 23, 2021

Conversation

willemneal
Copy link
Contributor

fixes #1971

Generic base classes have an issue where all instances regardless of generic are collected as instances of its virtual methods. This checks to make sure that only methods from classes that extend the generic base class are added to the virtual table.

@willemneal willemneal requested review from dcodeIO and MaxGraey July 15, 2021 18:09
dcodeIO
dcodeIO reviewed Jul 15, 2021
View reviewed changes
src/compiler.ts Outdated Show resolved Hide resolved
@willemneal willemneal requested review from MaxGraey and dcodeIO July 15, 2021 19:29
@willemneal
Copy link
Contributor Author

@dcodeIO @MaxGraey

Anything else needed for this?

@willemneal willemneal requested a review from dcodeIO July 19, 2021 13:13
@willemneal
Copy link
Contributor Author

@MaxGraey Thoughts?

@willemneal
Copy link
Contributor Author

@MaxGraey Are we waiting to release this with a major bump? It should be a patch and could be merged now.

@willemneal
Copy link
Contributor Author

@MaxGraey, this is bug is a blocker for me.

@MaxGraey MaxGraey merged commit 1958554 into AssemblyScript:main Jul 23, 2021
@MaxGraey
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxGraey MaxGraey MaxGraey approved these changes

@dcodeIO dcodeIO dcodeIO approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

class extends basis class with generic compile error
3 participants
@willemneal @MaxGraey @dcodeIO