Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add findLastIndex for Array and TypedArray (Stage 3) #1981

Merged
merged 6 commits into from
Jul 23, 2021
Merged

feat: Add findLastIndex for Array and TypedArray (Stage 3) #1981

merged 6 commits into from
Jul 23, 2021

Conversation

MaxGraey
Copy link
Member

@MaxGraey MaxGraey commented Jul 14, 2021 •
edited
Loading

Also some refactoring in Array.ts and TypedArray.ts for consistency

  • I've read the contributing guidelines

@MaxGraey MaxGraey marked this pull request as ready for review July 14, 2021 10:27
@MaxGraey MaxGraey requested a review from dcodeIO July 14, 2021 10:27
@MaxGraey
Copy link
Member Author

MaxGraey commented Jul 14, 2021 •
edited
Loading

btw we have a problem with unavailable nightly build again

@dcodeIO
Copy link
Member

dcodeIO commented Jul 14, 2021

It sometimes becomes available a bit later, may be that it just hasn't finished the build yet. Let's see :)

@MaxGraey
Copy link
Member Author

yeah

@MaxGraey MaxGraey merged commit a0307d8 into AssemblyScript:main Jul 23, 2021
@MaxGraey MaxGraey deleted the find-last-index branch July 23, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcodeIO dcodeIO dcodeIO left review comments

Assignees
No one assigned
Labels
compatibility standard library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxGraey @dcodeIO