Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add __newArrayBuffer() to the loader #1965

Merged
merged 3 commits into from
Jul 23, 2021
Merged

feat: add __newArrayBuffer() to the loader #1965

merged 3 commits into from
Jul 23, 2021

Conversation

FGasper
Copy link
Contributor

@FGasper FGasper commented Jul 9, 2021 •
edited by MaxGraey
Loading

  • I've read the contributing guidelines

@FGasper FGasper force-pushed the __newArrayBuffer branch from 97c071d to ff00498 Compare July 9, 2021 23:18
@FGasper
Copy link
Contributor Author

FGasper commented Jul 15, 2021

Nudging @MaxGraey and @dcodeIO (and any other maintainers?) … am I just waiting at this point for someone to approve the workflow run for this PR?

Thank you!

@FGasper FGasper force-pushed the __newArrayBuffer branch from ff00498 to 1ecd496 Compare July 15, 2021 12:21
@MaxGraey MaxGraey requested a review from dcodeIO July 15, 2021 12:28
MaxGraey
MaxGraey reviewed Jul 15, 2021
View reviewed changes
lib/loader/tests/index.js Outdated Show resolved Hide resolved
@MaxGraey
Copy link
Member

It seems your email doesn't associate with github account?

@FGasper
Copy link
Contributor Author

FGasper commented Jul 15, 2021

It seems your email doesn't associate with github account?

I have it set to private. I’ll update the PR.

@FGasper FGasper force-pushed the __newArrayBuffer branch from 07dfe9a to 079491f Compare July 15, 2021 12:42
@FGasper @MaxGraey
Add __newArrayBuffer() to the loader.
079491f 
This will facilitate passing binary strings more easily to AssemblyScript
from the host environment.

Co-authored-by: Max Graey <maxgraey@gmail.com>
MaxGraey
MaxGraey reviewed Jul 15, 2021
View reviewed changes
lib/loader/tests/index.js Outdated Show resolved Hide resolved
MaxGraey
MaxGraey reviewed Jul 15, 2021
View reviewed changes
NOTICE Outdated Show resolved Hide resolved
dcodeIO
dcodeIO approved these changes Jul 15, 2021
View reviewed changes
Copy link
Member

@dcodeIO dcodeIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MaxGraey MaxGraey changed the title Add __newArrayBuffer() to the loader. feat: add __newArrayBuffer() to the loader Jul 15, 2021
@MaxGraey MaxGraey merged commit 5df7318 into AssemblyScript:main Jul 23, 2021
@MaxGraey
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxGraey MaxGraey MaxGraey approved these changes

@dcodeIO dcodeIO dcodeIO approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FGasper @MaxGraey @dcodeIO