Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw unimplemented error when using spread operator #1926

Merged
merged 5 commits into from
Jun 28, 2021

Conversation

romdotdog
Copy link
Contributor

I'm not exactly sure what the current status of the spread operator is, but I noticed that the compiler crashes when using it
fixes #1853
all tests passed in my fork

  • I've read the contributing guidelines

@MaxGraey MaxGraey requested a review from dcodeIO June 26, 2021 17:27
@MaxGraey
Copy link
Member

Could you add your name & email in NOTICE?

@romdotdog
Copy link
Contributor Author

Done!

@MaxGraey
Copy link
Member

@romdotdog plz resync with master

@romdotdog
Copy link
Contributor Author

@MaxGraey @dcodeIO Finished

@MaxGraey
Copy link
Member

MaxGraey commented Jun 28, 2021

@dcodeIO Hmm, why it add extra 70765447+?

Author '70765447+romdotdog@users.noreply.github.com' does not appear to be listed in the NOTICE file, yet.

@dcodeIO
Copy link
Member

dcodeIO commented Jun 28, 2021

Seems like that's just the format these email addresses take. There is another one further above having a prefix.

@MaxGraey
Copy link
Member

Did you try AUTHOR=$(git log -1 --format="%ae" HASH^!) instead --format="%aE"?

@dcodeIO
Copy link
Member

dcodeIO commented Jun 28, 2021

We don't use mailmap, so doesn't seem related.

@dcodeIO
Copy link
Member

dcodeIO commented Jun 28, 2021

Btw, afaik the main part of the email is 70765447@, with the +something typically rather a tag. Not 100% sure what GH uses, ofc, but looks like they prefer a unique ID. Perhaps the name can change?

@MaxGraey
Copy link
Member

We don't use mailmap, so doesn't seem related.

But current %aE relate to mailmap

@romdotdog
Copy link
Contributor Author

Btw, afaik the main part of the email is 70765447@, with the +something typically rather a tag. Not 100% sure what GH uses, ofc, but looks like they prefer a unique ID. Perhaps the name can change?

This definitely makes sense. I just did git config --global user.email into my console and copied it 😅

@MaxGraey MaxGraey merged commit c441afd into AssemblyScript:main Jun 28, 2021
@MaxGraey
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meet error about ... operator
3 participants