Include env/RT in generated definitions #1901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failure is v8-canary missing builds. |
MaxGraey
reviewed
Jun 11, 2021
MaxGraey
reviewed
Jun 11, 2021
Co-authored-by: Max Graey <maxgraey@gmail.com>
Co-authored-by: Max Graey <maxgraey@gmail.com>
MaxGraey
approved these changes
Jun 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the definitions now being in a format that can be picked up by bundlers (anticipating ESM integration) even when not using the loader, it may be useful to also declare the memory and the table, as well as exported runtime helpers.
memoryif exportedtableif exported_startif explicit__new,__pin,__unpin,__collectand__rtti_baseif exported__setArgumentsLengthif there are exported varargs functionsAlso fixes #1900