Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use F_NOEXPORTRUNTIME if __rtti_base is missing #1808

Merged
merged 4 commits into from
Apr 15, 2021
Merged

Use F_NOEXPORTRUNTIME if __rtti_base is missing #1808

merged 4 commits into from
Apr 15, 2021

Conversation

MaxGraey
Copy link
Member

@MaxGraey MaxGraey commented Apr 15, 2021 •
edited
Loading

Fix #1807

  • I've read the contributing guidelines

@MaxGraey MaxGraey requested a review from dcodeIO April 15, 2021 18:16
dcodeIO
dcodeIO reviewed Apr 15, 2021
View reviewed changes
lib/loader/index.js Outdated Show resolved Hide resolved
dcodeIO
dcodeIO reviewed Apr 15, 2021
View reviewed changes
lib/loader/index.js Outdated Show resolved Hide resolved
@MaxGraey MaxGraey requested a review from dcodeIO April 15, 2021 18:56
dcodeIO
dcodeIO approved these changes Apr 15, 2021
View reviewed changes
Copy link
Member

@dcodeIO dcodeIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Feel free to merge :)

@MaxGraey MaxGraey merged commit 7e20ad2 into AssemblyScript:master Apr 15, 2021
@MaxGraey MaxGraey deleted the loader-add-error-for-neg-align branch April 15, 2021 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcodeIO dcodeIO dcodeIO approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loader __getArray, "unsupported align: -1"
2 participants
@MaxGraey @dcodeIO