Fix rounding #8
Closed
Fix rounding #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TempTarget rounding
|
No. It is rounded in a closure higher up already. Thus this PR serves no purpose |
|
@Jon-b-m try to put in 8.1mmol/L as temp target and when switch to mg/dL.
This commit fixes this and also that the data table displays converted TT with 2 decimals.
|
|
I tested current code. It converts fine already mmol/L <-> mg/dl. Your code is outdated. You need to sync updates. |
|
I did the screens just now with current dev.
|
dnzxy
pushed a commit
to dnzxy/iAPS
that referenced
this pull request
Dec 23, 2023
Swift charts fixes & refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was still the issue with 2 digits in the DateTable for tempTargets
also another place in TT state model