Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix class not found when unmarshalling for Samsung devices #332

Merged
merged 1 commit into from
Jul 6, 2017
Merged

Fix class not found when unmarshalling for Samsung devices #332

merged 1 commit into from
Jul 6, 2017

Conversation

Vantablack
Copy link
Contributor

Fix for #329
Tested on Samsung I9300 Galaxy S III 4.3

@Vantablack
Copy link
Contributor Author

Hey @ArthurHub! I've tested and it works by wrapping the Parcel in a Bundle see also

@ArthurHub ArthurHub merged commit c1f37bc into ArthurHub:master Jul 6, 2017
@ArthurHub
Copy link
Owner

Awesome! Thank you!
image

@Vantablack
Copy link
Contributor Author

Thanks for the fast reply too! 😊

@Vantablack Vantablack deleted the fix-parcel branch July 7, 2017 01:03
@vasskob
Copy link

vasskob commented Jul 7, 2017

Hey @ArthurHub! When did you plan publish this Fix?

@ArthurHub
Copy link
Owner

This weekend

@vasskob
Copy link

vasskob commented Jul 7, 2017

Thanks for you help. Issue #329 can be closed. Still have problem with Samsung on my app with JNI.

@Vantablack
Copy link
Contributor Author

Hey @vasskob I found this issue from another library which happens on, as quoted Nexus 5x, Android 7.0, Android build NBD90W (October 2016 security patches). Also linked was https://issuetracker.google.com/issues/37123764.

I'm suspecting it's some Android patches that are causing this issue (?) and not the library itself (it was also marked as a non-library bug in the other project).

@vasskob
Copy link

vasskob commented Jul 10, 2017

Thanks a lot, but i have tested my app also on Nexus 5X but all works fine.

@SUPERCILEX SUPERCILEX mentioned this pull request Sep 20, 2018
Closed
dimipaun added a commit to dimipaun/FirebaseUI-Android that referenced this pull request Sep 20, 2018
@dimipaun
Fix firebase#1416 - Wrap flow params into a Bundle to avoid a ClassNo…
37d6b68 
…tFoundException during unmarshaling.

See ArthurHub/Android-Image-Cropper#332
@dimipaun dimipaun mentioned this pull request Sep 20, 2018
Merged
dimipaun added a commit to dimipaun/FirebaseUI-Android that referenced this pull request Sep 20, 2018
@dimipaun
Fix firebase#1416 - Wrap flow params into a Bundle to avoid a ClassNo…
628717a 
…tFoundException during unmarshaling.

See ArthurHub/Android-Image-Cropper#332
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vantablack @ArthurHub @vasskob