Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept CharSequence for title in ActivityBuilder class #297

Closed
KentHawkings opened this issue Jun 6, 2017 · 1 comment
Closed

Accept CharSequence for title in ActivityBuilder class #297

KentHawkings opened this issue Jun 6, 2017 · 1 comment

Comments

@KentHawkings
Copy link

At the moment the ActivityBuilder class only accepts a String in the setActivityTitle() method. Ideally this would be a CharSequence. It's more "correct" since ActionBar.setTitle() accepts a CharSequence. Moreover, it would allow for more flexibility in theming the CropImageActivity. Some applications (such as my own) have a custom font so this would convenient in cases like those (and any other cases where users want to apply spans to an activity title).
ArthurHub added a commit that referenced this issue Jul 7, 2017
@ArthurHub
Use CharSequence instead of string for activity title (#297)
f78d486
@ArthurHub
Copy link
Owner

That is an excellent point, fixed in 2.4.7, thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KentHawkings @ArthurHub