Modify APIManager to make it possible to customize a bundleID. #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks, works well! Going to merger and make one minor change to comments. Will release shortly thereafter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone.
The main aspect of this PR is the addition of an entry that allows us to customize the bundleID for retrieving AppStore application information. Sometimes this is important because we release beta apps for different server endpoint with variants of primary bundleID. These bundleID variants were not released on the AppStore. So we need to customize the BundleID in APIManager for AppStore retrieval. Otherwise, from the perspective of QA, it's a BUG. 😄