Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some areas of the ending song subtitles cannot be refreshed #18

Closed
nyanmisaka opened this issue Nov 7, 2024 · 3 comments · Fixed by #19
Closed

Some areas of the ending song subtitles cannot be refreshed #18

nyanmisaka opened this issue Nov 7, 2024 · 3 comments · Fixed by #19
Assignees
@Arcus92
Labels
bug Something isn't working

Comments

@nyanmisaka
Copy link

1

As shown in the picture, the area to the right of the subtitles underlined in red has not been refreshed, they are from an earlier timestamp. If I seek the video to the beginning at this time, these unrefreshed areas will also remain on the screen. This problem does not exist in FFmpeg.

The timestamp of the ending song of this file starts at 01:24:57. Videos outside of the end credits have been censored.
@Arcus92 Arcus92 self-assigned this Nov 7, 2024
@Arcus92 Arcus92 added the bug Something isn't working label Nov 7, 2024
@Arcus92 Arcus92 mentioned this issue Nov 7, 2024
Merged
@Arcus92 Arcus92 linked a pull request Nov 7, 2024 that will close this issue
Fix clear-rect after recent position change #19
Merged
@Arcus92
Copy link
Owner

Arcus92 commented Nov 7, 2024

Hi @nyanmisaka,
Thanks so much for this sample. It uses some PGS features I couldn't test before.
The underlying issue was due to a misunderstanding of PGS windows.

@Arcus92
Copy link
Owner

Arcus92 commented Nov 7, 2024

Wasn't meant to end this message there...
The issue is now fix.
grafik
I'll create a backport PR for Jellyfin 10.10.2.

@Arcus92 Arcus92 mentioned this issue Nov 7, 2024
Merged
@nyanmisaka
Copy link
Author

Just tested it on my end and it works perfectly. Thanks for your quick response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arcus92 Arcus92

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix clear-rect after recent position change Arcus92/libpgs-js
2 participants
@Arcus92 @nyanmisaka