StS: Update location table and move item creation to create_items from generate_basic.
#1938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Until we get #1933 merged, don't forget to also increment |
ThePhar
changed the title
create_items from generate_basic.
ThePhar
added
is: maintenance
worlds/spire/Rules.py
Outdated
| set_rule(world.get_location("Heart Room", player), lambda state: state.has("Beat Act 3 Boss", player)) | ||
|
|
||
| if world.logic[player] != 'no logic': |
There was a problem hiding this comment.
? spire doesn't have a logic option does it?
There was a problem hiding this comment.
i was just copying the old bad minecraft code back when i did this bit.
el-u
reviewed
Jul 4, 2023
| @@ -29,7 +28,6 @@ | |||
| 'Relic 10': 20010, | |||
| 'Boss Relic 1': 22001, | |||
| 'Boss Relic 2': 22002, | |||
| 'Boss Relic 3': 22003, | |||
There was a problem hiding this comment.
Since this removes 2 locations from the pool while keeping the number of items the same, the StS world now causes unplaced items.
Fix item pool
ThePhar
approved these changes
Jul 4, 2023
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
…rom `generate_basic`. (ArchipelagoMW#1938)
kl3cks7r
pushed a commit
to kl3cks7r/Archipelago
that referenced
this pull request
Dec 15, 2023
…rom `generate_basic`. (ArchipelagoMW#1938)
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
…rom `generate_basic`. (ArchipelagoMW#1938)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
fixes spire in #1460
also removes the extra items that dont exist in base game.
How was this tested?
ran it against #1460 and it no longer triggers a fail for this test.