Ensure exo tests can run in parallel #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix regression in CI script * Ensure output files from different models don't conflict No changelog entry is needed for this. * Ensure the MOCAP variables exists before they are used # Conflicts: # Application/MocapExamples/BVH_BoxLift/Model/box.any
melund
changed the title
There was a problem hiding this comment.
I think this is a good idea and I can see another application for this for the users. We could actually think of extending this concept to all the saved outputs. Possible use case could be to use the same trial motion with different box weight/dimensions. It is not entirely accurate because actual motion would be different if box weight or dimensions are changed. But maybe it's a nice compromise. What do you think?
Comment on lines
+229
to
+230
| // We need to manually ensure these exists here because this code is included | ||
| // before the MoCap framework ensure that they are created. |
There was a problem hiding this comment.
It could make sense to add a description over here about what this code does for the user: that is they can save box outputs with specific prefixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No changelog entry is needed for this.