Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

These images are huge #24

Closed
inmanturbo opened this issue Jun 30, 2020 · 5 comments
Closed

These images are huge #24

inmanturbo opened this issue Jun 30, 2020 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@inmanturbo
Copy link

inmanturbo commented Jun 30, 2020

First I just want to say that is is great that someone is doing this. However when I pull this I end up with like a 40g volume (!).
I'm trying to set up a three node prototype for a kubernetes project on a small nested libvirt instance. I don't want to have to mount a san/nas volume with this instance as that will introduce some extras complexities regarding permissions that come along with using nfs for a libvirt pool that I don't want to bother with just for this little lab. And I don't want to put in another storage ticket. It shouldn't be necessary.

Anyway the thing crashes my vm and I had no idea why until I took a peak under the hood with virsh and saw this massive qcow2. Must the image be so large?

Thanks

@AntonioMeireles AntonioMeireles self-assigned this Jun 30, 2020
@AntonioMeireles AntonioMeireles added the enhancement New feature or request label Jun 30, 2020
@AntonioMeireles
Copy link
Owner

@inmanturbo

hi! first things first - thanks for finding my images useful :-)

box size ended being 40G for historical and consistency reasons - as it's the same size in the other variants for the remaining providers.

I can trivially take a lower default and update docs to point users to vagrant-livbirt's driver machine_virtual_size option which (quoting) ...

Sets the disk size in GB for the machine overriding the default specified in the box. Allows boxes to defined with a minimal size disk by default and to be grown to a larger size at creation time. Will ignore sizes smaller than the size specified by the box metadata. Note that currently there is no support for automatically resizing the filesystem to take advantage of the larger disk.

I'll take a look soonish at shrinking default size while at same time trying to transparently handle on my side the fs resize part which the vagrant-livbirt's driver doesn't do, so that ends being fully transparent to the end user.

thanks again!

@inmanturbo
Copy link
Author

inmanturbo commented Jul 1, 2020 via email

AntonioMeireles added a commit that referenced this issue Aug 17, 2020
Signed-off-by: António Meireles <antonio.meireles@reformi.st>
@AntonioMeireles
Copy link
Owner

@inmanturbo

Hi, (sorry the lag)

just committed the needed changes. Default size will be now 5G. if no issues arise in ongoing smoke testing this week images will already consume this changes.

Many thanks for your patience!

@inmanturbo
Copy link
Author

inmanturbo commented Aug 18, 2020 via email

AntonioMeireles added a commit to AntonioMeireles/cloud-native-setup that referenced this issue Aug 19, 2020
per AntonioMeireles/ClearLinux-packer#24 the
ClearLinux libvirt boxes default size was lowered from the previous 40G
to a more manageable 5G, having the user the ability to, at box
instantiation, to increase that value to whatever is adequate.

In order to avoid surprises in this side the Vagrantfile was modded to
have hardcoded the previous default value.

This change is forward and backward compatible as it will just be
ignored when using older boxes ( since the 'new' root volume size just
the same as original one) and will resize the box to the expected 40G in
newer ones.

Signed-off-by: António Meireles <antonio.meireles@reformi.st>
CraigSterrett pushed a commit to clearlinux/cloud-native-setup that referenced this issue Aug 19, 2020
…way (#330)

per AntonioMeireles/ClearLinux-packer#24 the
ClearLinux libvirt boxes default size was lowered from the previous 40G
to a more manageable 5G, having the user the ability to, at box
instantiation, to increase that value to whatever is adequate.

In order to avoid surprises in this side the Vagrantfile was modded to
have hardcoded the previous default value.

This change is forward and backward compatible as it will just be
ignored when using older boxes ( since the 'new' root volume size just
the same as original one) and will resize the box to the expected 40G in
newer ones.

Signed-off-by: António Meireles <antonio.meireles@reformi.st>
@AntonioMeireles
Copy link
Owner

@inmanturbo

just pushed 33650 boxes that consume this feature. they also work smoothly with latest vagrant (2.2.10) which got less stateless friendly than before.

Feel free to reopen or fill a new bug if issues arise.

Thanks, once again, for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants