Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge dev work into master #131

Merged
merged 103 commits into from
Apr 11, 2021
Merged

Merge dev work into master #131

merged 103 commits into from
Apr 11, 2021

Conversation

AnthonyBloomer
Copy link
Owner

No description provided.

sdfordham and others added 30 commits March 30, 2021 22:57
@sdfordham
(#91) New Daft class.
0838c98
@sdfordham
(#91) New Listing class.
152bd74
@sdfordham
(#91) Updated enums.
3529e66
@sdfordham
(#91) Add Location enum for ids.
fdb6a8d
@AnthonyBloomer
Remove v1 tests & examples
c3a80ed
@AnthonyBloomer
Update README.md
fbdb54d
@AnthonyBloomer
Updated imports and removed duplicate enum
f5f28a6
@AnthonyBloomer
Update listing.py
7df8b8c
@AnthonyBloomer
Update listing.py
045c45a
@sdfordham
Merge pull request #94 from AnthonyBloomer/update-listing-properties
54485a3 
Update listing properties
@sdfordham
(#93) . should be ,
ff3cfb1
@sdfordham
Merge pull request #93 from AnthonyBloomer/small-fixes
28b2a48 
Updated imports and removed duplicate enum
@sdfordham
Merge pull request #92 from AnthonyBloomer/remove-v1-tests-examples
90cc48d 
Remove v1 tests & examples
@sdfordham
Daft type checking .
072e7b4
@AnthonyBloomer
Merge pull request #97 from AnthonyBloomer/daft-type-check
9393420 
Daft type checking.
@AnthonyBloomer
Updated README and added some examples.
da5cc8f
@AnthonyBloomer
Fix method
805cf1a
@AnthonyBloomer
Update listing.py
c3d5257
@sdfordham
Merge pull request #99 from AnthonyBloomer/remove-properties
0348836 
Removed redundant properties
@sdfordham
Merge pull request #98 from AnthonyBloomer/documentation
2896aeb 
Updated README and added some examples.
@AnthonyBloomer
Added more listing methods
7ebae40
@sdfordham
Allow to specify max pages of results.
68ead8a
@AnthonyBloomer
Merge pull request #101 from AnthonyBloomer/allow-limit-search
631397c 
Allow to specify max pages of results.
@sdfordham
Merge pull request #100 from AnthonyBloomer/more-listing-stuff
a94d211 
Added more listing methods
@sdfordham
(#103) Fix bad enum val
1d612c7
@sdfordham
(#103) range -> ranges
6cd9ebb
@sdfordham
(#103) Set price range based on searchtype.
1d5920c
@AnthonyBloomer
Merge pull request #105 from AnthonyBloomer/search-filter-not-applied…
d957e34 
…-issue-103

Search filter not applied issue 103
@AnthonyBloomer
Added sort filter
15dbf43
@sdfordham
Merge pull request #106 from AnthonyBloomer/sort-filter
3ad9688 
Added sort filter
AnthonyBloomer and others added 25 commits April 5, 2021 14:10
@AnthonyBloomer
Merge pull request #122 from EricNeville/facilities-filtering
7fcd27b 
Facilities filtering
@AnthonyBloomer
Added some more tests
3c0b589
@sdfordham
Merge pull request #123 from AnthonyBloomer/more-tests
b6dc469 
Added some more tests
@sdfordham
Set encoding.
6c1c1a7
@AnthonyBloomer
Merge pull request #127 from AnthonyBloomer/eunit-test
9f55f8a 
Set encoding.
@AnthonyBloomer
Add featured level to listing #124
dc01724
@AnthonyBloomer
Revert "Add featured level to listing #124"
400a26e 
This reverts commit dc01724.
@AnthonyBloomer
Add Featured level
24bbd52
@sdfordham
Merge pull request #128 from AnthonyBloomer/featured-level
0ba374b 
Add featured level to Listing
@EricNeville
fixing incorrect results relating to grouped listings in the same dev…
64dfc68 
…elopment
@EricNeville
Correct number of results output
2e60ab3
@EricNeville
Fix accidental removal of section initialisation
dea5c17
@EricNeville
Remove abbreviated price from test
e5b74a5
@EricNeville
Accounting for search type and property type to fix previous errors
257c414
@EricNeville
Put back test line accidentally removed
bbc1b54
@EricNeville
make sublistings work for more search types, also set numBedrooms for…
3ac68ec 
… studios
@EricNeville
Remove abbreviated price test as the attribute has been removed
dbe7e22
@EricNeville
Fix compatibility with test_listing
7154a04
@EricNeville
Add New_Homes test for coverage
d97585d
@EricNeville
Updated visualisation to cluster listings at the same location
e5a3996
@EricNeville
Account for removal of abbreviated price in listings, documentation a…
2577cd8 
…nd examples. Change if else to try except in Daft.search().
@AnthonyBloomer
Merge pull request #129 from EricNeville/sublistings
0aaf003 
Sublistings
@AnthonyBloomer
Added total results variable
7e4b500
@AnthonyBloomer
search complete message
5ba60f2
@EricNeville
Merge pull request #130 from AnthonyBloomer/total-results
d20f7ac 
Added total results variable
@codecov
Copy link

codecov bot commented Apr 11, 2021 •
edited
Loading

Codecov Report

Merging #131 (75b038f) into master (6c0c6f7) will increase coverage by 16.82%.
The diff coverage is 86.75%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #131       +/-   ##
===========================================
+ Coverage   81.47%   98.29%   +16.82%     
===========================================
  Files           9        6        -3     
  Lines        1128     4637     +3509     
===========================================
+ Hits          919     4558     +3639     
+ Misses        209       79      -130
Impacted Files Coverage Δ
daftlistings/__init__.py 100.00% <ø> (ø)
daftlistings/location.py 100.00% <ø> (ø)
daftlistings/map_visualization.py 24.48% <6.25%> (-3.72%) ⬇️
daftlistings/daft.py 86.22% <85.93%> (+9.20%) ⬆️
daftlistings/listing.py 88.63% <87.05%> (+13.30%) ⬆️
daftlistings/enums.py 100.00% <100.00%> (+4.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec9e1ce...75b038f. Read the comment docs.

@AnthonyBloomer AnthonyBloomer merged commit e816b79 into master Apr 11, 2021
AnthonyBloomer added a commit that referenced this pull request Apr 11, 2021
@AnthonyBloomer
Merge pull request #132 from AnthonyBloomer/master
d486c35 
Merge pull request #131 from AnthonyBloomer/dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AnthonyBloomer @sdfordham @EricNeville @YifeiLu-1