feat: Option to show a custom window title #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optional window title can now be provided with --window-title. Total image width takes into account title width, when greater than lines.
Removed hardcoded values and added default params to draw window controls. Window title gets affected by this, as well.
|
LGTM |
Aloxaf
changed the title
|
I have the last release silicon 0.5.1 (october 2022) and this feature is not available yet (november 2022). @Aloxaf Have you planned to release a new version soon? |
|
+1, I also thought that this was available given that it was in the README but was disappointed when I found that this is not in the latest release. @Aloxaf any idea on when the next release will come out with this feature? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Window title by passing a value to option
--window-title:silicon --from-clipboard -l rs --to-clipboard --window-title "src/bin/silicon/config.rs"closes #180