Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Change Windows build target #175

Merged
merged 1 commit into from
Sep 27, 2021
Merged

ci: Change Windows build target #175

merged 1 commit into from
Sep 27, 2021

Conversation

rashil2000
Copy link
Contributor

Closes #171

@rashil2000
Copy link
Contributor Author

Also, would you mind editing the current release to use the MSVC binary (linked below) instead? It was generated through the runner in my fork, you can see the run here - https://github.com/rashil2000/silicon/actions/runs/1113723609)

https://github.com/rashil2000/silicon/releases/download/v0.4.3/silicon-v0.4.3-x86_64-pc-windows-msvc.tar.gz

@rashil2000
Copy link
Contributor Author

@Aloxaf bump?

@Aloxaf Aloxaf changed the title Change Windows build target ci: Change Windows build target Sep 27, 2021
@Aloxaf Aloxaf merged commit 463bd23 into Aloxaf:master Sep 27, 2021
@Aloxaf
Copy link
Owner

Aloxaf commented Sep 27, 2021

Thanks!

@rashil2000 rashil2000 deleted the release-windows branch October 1, 2021 05:34
@rashil2000
Copy link
Contributor Author

Hey @Aloxaf
You didn't update the release binary?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use MSVC toolchain for Windows release builds
2 participants
@rashil2000 @Aloxaf