Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solidity language, supported by bat, is not supported by Silicon #199

Closed
AndydeCleyre opened this issue Jun 28, 2022 · 3 comments
Closed

Comments

@AndydeCleyre
Copy link

This works:

$ silicon -o debug.png -l sh --theme Coldark-Dark <<<'// This is a type for a single proposal.
struct Proposal {
    bytes32 name;   // short name (up to 32 bytes)
    uint voteCount; // number of accumulated votes
}'

But these don't:

$ silicon -o debug.png -l sol --theme Coldark-Dark <<<'// This is a type for a single proposal.
struct Proposal {
    bytes32 name;   // short name (up to 32 bytes)
    uint voteCount; // number of accumulated votes
}'
[error] Unsupported language: sol
$ silicon -o debug.png -l Solidity --theme Coldark-Dark <<<'// This is a type for a single proposal.
struct Proposal {
    bytes32 name;   // short name (up to 32 bytes)
    uint voteCount; // number of accumulated votes
}'
[error] Unsupported language: Solidity

Meanwhile:

$ batcat --list-languages | grep -i solidity
Solidity:sol
$ batcat --version
bat 0.19.0
$ silicon --version
silicon 0.4.3
$ grep -Ei 'name|version' /etc/os-release
NAME="Pop!_OS"
VERSION="22.04 LTS"
PRETTY_NAME="Pop!_OS 22.04 LTS"
VERSION_ID="22.04"
VERSION_CODENAME=jammy
UBUNTU_CODENAME=jammy
@AndydeCleyre
Copy link
Author

I think in addition to regenerating the assets from bat, this will require a major syntect upgrade, and I don't know what else.

AndydeCleyre added a commit to AndydeCleyre/silicon that referenced this issue Jun 29, 2022
Fixes Aloxaf#199 (Adds Solidity syntax support)

The sync_from_bat script now pins the bat version used,
and that version was installed on the host,
for the bat cache command to match.
@AndydeCleyre
Copy link
Author

Well the latest versions of bat and syntect had complicating changes, so just using bat v0.18.1 was much simpler and does include the Solidity syntax definition.

Aloxaf added a commit that referenced this issue Oct 13, 2022
@Aloxaf Aloxaf closed this as completed Oct 13, 2022
@AndydeCleyre
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants