Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest update is failing to compile #158

Closed
augustocdias opened this issue Mar 3, 2021 · 16 comments
Closed

Latest update is failing to compile #158

augustocdias opened this issue Mar 3, 2021 · 16 comments

Comments

@augustocdias
Copy link

Installing through cargo install.

   Compiling pasteboard v0.1.2
error[E0308]: mismatched types
  --> /Users/augusto/.cargo/registry/src/github.com-1ecc6299db9ec823/pasteboard-0.1.2/src/lib.rs:75:12
   |
75 |         if ok {
   |            ^^ expected `bool`, found `i8`

error[E0308]: mismatched types
  --> /Users/augusto/.cargo/registry/src/github.com-1ecc6299db9ec823/pasteboard-0.1.2/src/lib.rs:82:59
   |
82 |             NSData::writeToFile_atomically_(object, path, false);
   |                                                           ^^^^^ expected `i8`, found `bool`

error: aborting due to 2 previous errors
@Aloxaf
Copy link
Owner

Aloxaf commented Mar 3, 2021

Are you using Big Sur?

@augustocdias
Copy link
Author

Yes I am @Aloxaf

@segeljakt
Copy link

Which version of big sur are you running?

@augustocdias
Copy link
Author

11.2.2

@Aloxaf
Copy link
Owner

Aloxaf commented Mar 4, 2021

@segeljakt It seems that not all Big Sur run on arm device.

Replacing custom big_sur_update with target_arch = "aarch64" may be a better choice?

ref. https://github.com/SSheldon/rust-objc/blob/master/src/runtime.rs#L27-L28

@segeljakt
Copy link

Ok, interesting, I can upload a patch later today

@augustocdias
Copy link
Author

Any update on this?

@chenrui333
Copy link

Any update on this (as it does impact on the silicon 0.4.1 build)?

Aloxaf added a commit that referenced this issue Apr 26, 2021
@Aloxaf
Copy link
Owner

Aloxaf commented Apr 26, 2021

@chenrui333 I dropped the clipboard support on macOS arm. Please check if it could be built on macOS Big Sur now.

@mikemadden42
Copy link

I see this same issue.

$ rustc --version
rustc 1.52.1 (9bc8c42bb 2021-05-09)

$ sw_vers
ProductName:	macOS
ProductVersion:	11.3.1
BuildVersion:	20E241
error[E0308]: mismatched types
  --> /Users/mjm/.cargo/registry/src/github.com-1ecc6299db9ec823/pasteboard-0.1.2/src/lib.rs:75:12
   |
75 |         if ok {
   |            ^^ expected `bool`, found `i8`

error[E0308]: mismatched types
  --> /Users/mjm/.cargo/registry/src/github.com-1ecc6299db9ec823/pasteboard-0.1.2/src/lib.rs:82:59
   |
82 |             NSData::writeToFile_atomically_(object, path, false);
   |                                                           ^^^^^ expected `i8`, found `bool`

error: aborting due to 2 previous errors

For more information about this error, try `rustc --explain E0308`.
error: could not compile `pasteboard`

To learn more, run the command again with --verbose.
warning: build failed, waiting for other jobs to finish...
error: build failed

@Aloxaf
Copy link
Owner

Aloxaf commented May 14, 2021

@mikemadden42 Can git version be compiled?

@segeljakt
Copy link

segeljakt commented May 14, 2021

Big apologies for the long wait. I pushed an update to pasteboard (now pasteboard = 0.1.3) which should hopefully fix this issue. If not then please report back. It works for me now on macOS 11.4.0.

@mikemadden42
Copy link

Thanks @segeljakt . Updating to pasteboard v0.1.3 fixed the build issue I was seeing on macOS Big Sur.

@mikemadden42
Copy link

@segeljakt @Aloxaf Do you think we should update this version of pasteboard in master so this builds cleanly on macOS Big Sur?

https://github.com/Aloxaf/silicon/blob/master/Cargo.toml#L25

@Aloxaf
Copy link
Owner

Aloxaf commented May 24, 2021

@segeljakt Thanks!

@mikemadden42 Done!

@chenrui333
Copy link

I can confirm this commit fixed the build issue, and we have made the upgrade in the homebrew-core side

@Aloxaf Aloxaf closed this as completed Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants