-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow zero for --highlight-lines
value
#124
Comments
Yeah, strange you don't see the segfault. If it helps, here is some extra diagnostic info:
|
Hey @Aloxaf, will you be releasing a new Homebrew version with the above fix soon? I'd love to pick up this fix if possible. 😉 |
Ok. I will make a release soon. |
Awesome, thanks and thanks for the fix too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Overview
Would it be possible to allow zero as a safe value for
--highlight-lines
? Example:Essentially, a value of zero would be like a no-op and as if the
--highlight-lines
option was never used. The reason why this is valuable is for wrapping in a shell script. Without this being possible, the following error happens instead:Screenshots/Screencasts
Here is an example of a shell script that sets
--highlight-lines
to zero as a default option which will fail with the above mentioned error. It would be nice to allow zero in this situation.Steps to Recreate
Desired Behavior
Don't throw a segfault and ignore
--highlight-lines
instead since it's a no-op.The text was updated successfully, but these errors were encountered: