-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove while True
in AgentController
#5868
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enyst
reviewed
Dec 27, 2024
enyst
reviewed
Dec 27, 2024
enyst
reviewed
Dec 28, 2024
enyst
reviewed
Dec 28, 2024
tofarr
approved these changes
Dec 31, 2024
Co-authored-by: Robert Brennan <accounts@rbren.io>
enyst
approved these changes
Dec 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The exclusions in should_step
include the filter_out
class var values. That looks right to me.
FWIW, I did look for ways that will break this PR, related to should_step
. I didn't find something that will break. 😅 🤷♂️
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End-user friendly description of the problem this fixes or functionality that this introduces
no changelog
Give a summary of what the PR does, explaining any non-trivial design decisions
The
while True
here is causing a lot of problems. It's easy for it to get stuck permanently.Removing that loop is a surprisingly simple change--we just
_step
the agent whenever a new event comes in that it might react to. Haven't fully tested this yet but at first blush it's working well.However, doing that surfaced a bunch of subtle issues with EventStream callbacks blocking each other, as well as main parts of the app. So now:
Link of any specific issues this addresses
To run this PR locally, use the following command: