Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for more browsers on Linux #516

Merged
merged 2 commits into from Jul 1, 2020
Merged

Add support for more browsers on Linux #516

merged 2 commits into from Jul 1, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jul 1, 2020

Chromium-based:

  • SlimJet
  • Dissenter-Browser

Firefox-based:

  • IceCat
  • WaterFox

Some notes:

I removed Cyberfox because it is an outdated browser which hasn't been updated in several years.
The remaining Firefox-based browser commented out to test are unavailable for Linux.

I also tested several browser which didn't work. I left them commented out with FIXME notations in case someone wants to look at them:

  • SuperBird: This one had a lot of tracebacks, presumably it uses a different method for storing the passwords than standard Chromium-based browsers.
  • Vivaldi & Whale: These are a little weird. They each (if included individually, or the last of both if you uncomment both of them) fail at this line.
    password = password if python_version == 2 else password.decode()
  • Pale Moon: This is a browser based on an old version of Firefox. Perhaps the Firefox code we have only supports newer versions, or maybe they use a different method, but it doesn't work right now.

Chromium-based:
- SlimJet
- Dissenter-Browser

Firefox-based:
- IceCat
- WaterFox
@ghost ghost changed the title Add support for more browsers Add support for more browsers on Linux Jul 1, 2020
@AlessandroZ AlessandroZ merged commit 3dedb85 into AlessandroZ:master Jul 1, 2020
@AlessandroZ
Copy link
Owner

Awesome thanks !!

@ghost ghost deleted the chrome branch July 1, 2020 14:34
@ghost ghost mentioned this pull request Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant