merge interfaces

AlbertoCentonze · Nov 5, 2024 · fe609dc · fe609dc
1 parent 0abcf45
commit fe609dc
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 18 deletions.
diff --git a/vyper/builtins/interfaces/IERC20.vyi b/vyper/builtins/interfaces/IERC20.vyi
@@ -36,3 +36,22 @@ def transferFrom(_from: address, _to: address, _value: uint256) -> bool:
 @external
 def approve(_spender: address, _value: uint256) -> bool:
     ...
+
+#NOTE: interface uses `String[1]` where 1 is the lower bound of the string returned by the function.
+#    For end-users this means they can't use `implements: ERC20Detailed` unless their implementation
+#    uses a value n >= 1. Regardless this is fine as one can't do String[0] where n == 0.
+
+@view
+@external
+def name() -> String[1]:
+    ...
+
+@view
+@external
+def symbol() -> String[1]:
+    ...
+
+@view
+@external
+def decimals() -> uint8:
+    ...
diff --git a/vyper/builtins/interfaces/IERC20Detailed.vyi b/vyper/builtins/interfaces/IERC20Detailed.vyi