Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing ORDER BY direction when calling toString() on AST #970

Merged
merged 1 commit into from
Jan 18, 2018
Merged

Fix missing ORDER BY direction when calling toString() on AST #970

merged 1 commit into from
Jan 18, 2018

Conversation

alexpeattie
Copy link
Contributor

Closes #965

An ORDER BY statement is a yy.Expression which has a direction and expression property:

screen shot 2018-01-17 at 11 40 43

But direction was previously ignored by yy.Expression.toString().

@codecov-io
Copy link

Codecov Report

Merging #970 into develop will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #970      +/-   ##
==========================================
+ Coverage    67.16%   67.2%   +0.04%     
==========================================
  Files            1       1              
  Lines        10489   10491       +2     
  Branches      3134    3135       +1     
==========================================
+ Hits          7045    7051       +6     
+ Misses        3444    3440       -4
Impacted Files Coverage Δ
dist/alasql.fs.js 67.2% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d997e41...283d522. Read the comment docs.

@mathiasrw
Copy link
Member

Thank you!

@mathiasrw mathiasrw merged commit b6a06e6 into AlaSQL:develop Jan 18, 2018
@alexpeattie alexpeattie deleted the fix-missing-order-direction-from-ast branch January 18, 2018 08:56
@mathiasrw mathiasrw mentioned this pull request Feb 9, 2018
Closed
jacqt pushed a commit to jacqt/alasql that referenced this pull request Jan 1, 2019
@alexpeattie @mathiasrw
Fix missing ORDER BY direction when calling toString on AST (AlaSQL#970)
160d9e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexpeattie @codecov-io @mathiasrw