Use created database id on foreign key check as default database id #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #921 +/- ##
===========================================
+ Coverage 67.95% 67.99% +0.04%
===========================================
Files 1 1
Lines 9915 9915
Branches 2965 2965
===========================================
+ Hits 6738 6742 +4
+ Misses 3177 3173 -4
Continue to review full report at Codecov.
|
mathiasrw
requested changes
Jul 28, 2017
test/test616.js
Outdated
| db.exec("INSERT INTO Parent(ParentId) VALUES(1)"); | ||
| db.exec("INSERT INTO Child(ChildId) VALUES(1)"); | ||
| done(); | ||
| }); |
There was a problem hiding this comment.
Thank you so much for also including a test.
We need to also include tests demonstrating aspects like
- Has data has been stored in parent correctly?
- Has data has been stored in child correctly?
- A scenario where the
referencepart is actively demonstrated (normally by doing something that gives one result with thereferenceand another result without thereference)
There was a problem hiding this comment.
It's just an exception fix
|
Awesome - thanks 👍 |
mathiasrw
approved these changes
Aug 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.