Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typos and missing dependency #53

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Conversation

notoookay
Copy link
Contributor

Hi, when I followed the instruction from README, I got some issues:

  • some typos
  • I noticed the training data on huggingface has been changed from full_output_1005.jsonl to train.jsonl, meanwhile, I didn't find training data downloaded via retrieval_lm/download_demo_corpus.sh, maybe I missed some details
  • seems like faiss is used during retriving, but no dependency neither in requirements.txt nor environment.yml

maybe you can check these, I don't know if I'm doing right.

@AkariAsai AkariAsai merged commit 141dd48 into AkariAsai:main Mar 19, 2024
@AkariAsai
Copy link
Owner

Thank you for PR! Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants