Check kyber in CI #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msprotz
approved these changes
Aug 21, 2024
|
why is this test failing? is it known? |
|
Yeah it seems I need to set the right version of karamel like I did for charon. This is a known limitation of nix flakes |
|
ok then if you think this is good please go ahead and merge |
Nadrieril
force-pushed
the
kyber-ci
branch
3 times, most recently
from
07e9d9e
to
49751b2
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
This is too slow to be practical. Let's move to our self-hosted runner, it has good nix caching. |
Nadrieril
force-pushed
the
kyber-ci
branch
3 times, most recently
from
6e56c3a
to
21406a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I do it in the charon side, it makes sense to do it here as well.