Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Almost all apps are no longer logged as filtered #5426

Closed
5 of 6 tasks
TPS opened this issue Aug 9, 2024 · 22 comments
Closed
5 of 6 tasks

Almost all apps are no longer logged as filtered #5426

TPS opened this issue Aug 9, 2024 · 22 comments
Assignees
@Deneno
Labels
Bug Junior+ Priority: P1 Resolution: Fixed Status: Closed Version: AdGuard v4.7
Milestone
4.7

Comments

@TPS
Copy link
Contributor

TPS commented Aug 9, 2024 •
edited
Loading

Please answer the following questions for yourself before submitting an issue

  • Filters were updated before reproducing an issue
  • I checked the knowledge base and found no answer
  • I checked to make sure that this issue has not already been filed

AdGuard version

4.7n6 updated to 4.7n7 → n9

Environment

  • OS version: Android 12 stock
  • Device: 1+ N200 5g

HTTPS filtering

  • yes, I do

Root access

  • yes, I have it

Integration with AdGuard VPN

  • yes, I do

Routing mode

Local VPN

Ad Blocking

AdGuard Base filter, AdGuard Mobile Ads filter

Privacy

AdGuard Tracking Protection filter, AdGuard URL Tracking filter, Legitimate URL Shortener, Peter Lowe's Blocklist

Social

AdGuard Social Media filter

Annoyances

AdGuard Annoyances filter, I don't care about cookies, Dandelion Sprout's Annoyances List

Security

Online Malicious URL Blocklist, NoCoin Filter List

Language-specific

AdGuard Chinese filter, AdGuard Dutch filter, AdGuard French filter, AdGuard German filter, AdGuard Japanese filter, AdGuard Russian filter, AdGuard Spanish/Portuguese filter, AdGuard Turkish filter, AdGuard Ukrainian filter, Polish Anti-Annoying Special Supplement, Polish GDPR-Cookies Filters, RU AdList - Counters

Other

AdGuard Experimental filter

Which DNS server do you use?

Open DNS

DNS protocol

DNS-over-HTTPS

Custom DNS

No response

What Stealth Mode options do you have enabled?

Block trackers, Remove tracking parameters from URLs, Hide your search queries, Ask websits not to track you, Self-destruction of third-party cookies, Block ETag and If-None-Match headers, Disable WebRTC, Block Push API, Block Location API, Hide your Referrer from third-parties, Hide your User Agent, Hide your IP address, Protect against DPI

Issue Details

Steps to reproduce:

  1. Update to AGa v4.7n7 to n9
  2. Browse via aEdge v127.0.2651.90 for some time
  3. Check Assistant or Recent Activity

Expected Behavior

Browser filtering should be logged

Actual Behavior

No browser filtering logged, only DNS filtering

Screenshots

The test page shows everything's as expected, so I'm hoping this is just a log glitch.

AdGuard test page

The cosmetic filter block page is active.

AG block page.16.png

Additional Information

Previous versions would log as filtering Edge.
@TPS TPS added the Bug label Aug 9, 2024
@adguard-bot adguard-bot assigned ESurina and unassigned Versty Aug 9, 2024
@AdamWr
Copy link
Member

AdamWr commented Aug 10, 2024

I have the same issue but in my case I don't see requests from any browser Chrome/Edge/Firefox (it looks like that only DNS requests are visible in "Recent activity", but ad filtering works correctly).

@vonDubenshire
Copy link

I finally got fed up with this and came to see if it had been reported yet since it started a couple of Nightly updates ago, I guess .9

I'm on 4.7.11 and I haven't seen any browser appear in the list of apps inside the AdGuard Assistant since 4.7.9 as @TPS noted.

@AdamWr yep same issue here.

I'm attaching current screenshot. It doesn't show any browsing I did to get here.
Screenshot_20240810-053100
Screenshot_20240810-053102

@Rtizer-9
Copy link

Rtizer-9 commented Aug 10, 2024 •
edited
Loading

I talked to the developer and Cosmetic Filtering IS applied which you can check in any browser or any app which is being filtered; it's just not shown in the filtering log due to HTTP events not displaying in the filtering log. So we can safely upgrade because the filtering is happening indeed and hopefully the display will be resolved in next nightly.

@TPS TPS changed the title MS Edge browser is no longer logged as filtered Browsers are no longer logged as filtered Aug 10, 2024
@Vstory
Copy link

Vstory commented Aug 12, 2024

Not only the browser, but all application filters are not displayed, only DNS filtering requests are displayed.

@pannal
Copy link

pannal commented Aug 12, 2024

Same here.

@TPS
Copy link
Contributor Author

TPS commented Aug 12, 2024 •
edited
Loading

Oddly, I still see very few apps having some logs, such as some UDP from a comm app, or rarely element removal even from Edge, but, like others here, the sheer quantity of these app logs is probably ~100× less.

I wonder whether this is from someone trying to solve #3421 (comment) &/or #5407.

So we can safely upgrade because the filtering is happening indeed and hopefully the display will be resolved in next nightly.

@Rtizer-9 Unfortunately, this makes very difficult to debug filter problems, so "safely" is a stretch.

@ESurina
Copy link

ESurina commented Aug 13, 2024

We will fix this in future versions!

@adguard-bot adguard-bot changed the title Browsers are no longer logged as filtered Almost all apps are no longer logged as filtered Aug 13, 2024
@Rtizer-9
Copy link

Guys I mean this is a nightly version so it'll have bugs, and there's no forced update so just downgrade if you want to see the cosmetic filtering in the log.

As mentioned already cosmetic filtering is working perfectly and the bug will be solved in the upcoming version.

@Vstory
Copy link

Vstory commented Aug 13, 2024

This is a bug, we are just reporting it so the developers can fix it.

@Rtizer-9
Copy link

Right and the dev team are already aware of this as I've already mentioned.

@pannal
Copy link

pannal commented Aug 13, 2024

How do I downgrade the nightly?

@Rtizer-9
Copy link

Export settings from settings tab 3 dot menu > uninstall current version and install 4.7.6 version and import those settings.

If you've root access and signature spoofing enabled you can simply install previous version over later version without uninstalling.

@pannal
Copy link

pannal commented Aug 13, 2024

Thank you. Is there a way to get a specific nightly?

@Rtizer-9
Copy link

Rtizer-9 commented Aug 13, 2024 •
edited
Loading

Join tg group and you'll get answers to all of your queries from the dev team itself.

@Rtizer-9
Copy link

https://t.me/adguard_en/237077

@TPS
Copy link
Contributor Author

TPS commented Aug 21, 2024

This looks fixed in v4.7n12. Y'all concur?

@smexyy
Copy link

smexyy commented Aug 21, 2024

This looks fixed in v4.7n12. Y'all concur?

I think partially fixed.

@TPS
Copy link
Contributor Author

TPS commented Aug 21, 2024

I think partially fixed.

What's yet missing?

@smexyy
Copy link

smexyy commented Aug 21, 2024

I think partially fixed.

What's yet missing?

It filter browser for 3 or 4 minutes, then only dns logs only. I cannot see https,tcp filtering for the browser

@TPS
Copy link
Contributor Author

TPS commented Aug 22, 2024

It filter browser for 3 or 4 minutes, then only dns logs only. I cannot see https,tcp filtering for the browser

I don't see this at all, but everything WFM as before this broke.

@smexyy What's your environment (more specifically, the answers to the template questions from 1st post here)?

@smexyy
Copy link

smexyy commented Aug 23, 2024

It filter browser for 3 or 4 minutes, then only dns logs only. I cannot see https,tcp filtering for the browser

I don't see this at all, but everything WFM as before this broke.

@smexyy What's your environment (more specifically, the answers to the template questions from 1st post here)?

Its andoid 13, android one, Adguard 4.7.23 nightly. I will retry later.

@smexyy
Copy link

smexyy commented Aug 24, 2024

It filter browser for 3 or 4 minutes, then only dns logs only. I cannot see https,tcp filtering for the browser

I don't see this at all, but everything WFM as before this broke.

@smexyy What's your environment (more specifically, the answers to the template questions from 1st post h

It filter browser for 3 or 4 minutes, then only dns logs only. I cannot see https,tcp filtering for the browser

I don't see this at all, but everything WFM as before this broke.

@smexyy What's your environment (more specifically, the answers to the template questions from 1st post here)?

I tested the latest release, and it seems to be running smoothly.

@maxikuzmin maxikuzmin added this to the 4.7 milestone Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Deneno Deneno

Labels
Bug Junior+ Priority: P1 Resolution: Fixed Status: Closed Version: AdGuard v4.7
Projects
None yet
Milestone
4.7
Development

No branches or pull requests