fix: ci and e2e test #383
fix: ci and e2e test #383
Conversation
- use chrome as being done in CI - Narrow down Selector to div with alert class else larger vue app dialog will be matched
Codecov ReportBase: 25.35% // Head: 25.05% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #383 +/- ##
==========================================
- Coverage 25.35% 25.05% -0.31%
==========================================
Files 26 27 +1
Lines 1471 1489 +18
Branches 235 240 +5
==========================================
Hits 373 373
- Misses 1068 1086 +18
Partials 30 30
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
* fix: Display proper error content in e2e test - use chrome as being done in CI - Narrow down Selector to div with alert class else larger vue app dialog will be matched * Update nodejs.yml * fix: check errors after taking screenshot
- add contents of loading elements if found to log since >95% of CI errors are on timeouts as of now
- github runners genuinely takes more time to load timeline view (as can be confirmed from previous ci-runs (logs and screenshots) of this pr
- since 40s is also not enough sometimes for loading timeline
- it seems like the indefinite wait is not working, pointing to some other issues - went bank to 20s wait time + Extra logging of browser console and dumping HTTP requests of non js css font image requests
|
Update: sometimes aw-server-rust(Rocket) is not even getting the requests - https://github.com/ActivityWatch/aw-webui/actions/runs/3341509927/jobs/5532792619#step:15:355 even when webui sent the request - https://github.com/ActivityWatch/aw-webui/actions/runs/3341509927/jobs/5532792619#step:12:275 - weird |
|
The issue can be in testcafe, node, github-actions, or rocket internals none of which are in the scope of this organization. Guess we have to stick to the refresh-if-loading not dissapers workarround for now. If even this workarround fails, all we can do is just increase the refresh values in https://github.com/ActivityWatch/aw-webui/pull/383/files#diff-409ad53159fcbc018c9fbe758b15f440bcef12d37127ead30403a3d528e30a55R8-R10. We can also start building for rust-server-nightly, any reason its commented out @ErikBjare ? |
There was a problem hiding this comment.
Very nice!
Merging ActivityWatch/aw-server-rust#310 now.
Anything left to do here?
We can also start building for rust-server-nightly, any reason its commented out?
Feels like CI abuse to have it on all the time, feel free to enable if it helps you :)
|
Thanks for the review and great comments :3 We need to even have windows and mac os builds-and-test for atleast each for the latest release version of server and master of server. For now, this is it. |
|
Very nice! Thank you so much for this ❤️ |
e2e test
Selectorto div withalertclass else larger vue app dialog will be matchedSelector).countis>0(https://github.com/ActivityWatch/aw-webui/actions/runs/3333810551/jobs/5516122757#step:12:58)Loading...element content for debuggingLoading...does not dissapear after sometimeUpdate nodejs.yml test job in CI