feat: added support for query caching in aw-client #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fetch bucket events if vis_timeline is not in the Activity view
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #501 +/- ##
==========================================
- Coverage 24.00% 23.94% -0.06%
==========================================
Files 27 27
Lines 1600 1604 +4
Branches 266 267 +1
==========================================
Hits 384 384
- Misses 1191 1195 +4
Partials 25 25 ☔ View full report in Codecov by Sentry. |
ErikBjare
commented
Nov 15, 2023
| @@ -306,6 +306,7 @@ export default { | |||
| }, | |||
| methods: { | |||
| getTimelineBuckets: async function () { | |||
| if (this.type != 'vis_timeline') return; | |||
There was a problem hiding this comment.
This got rid of a ton of unnecessary requests!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on ActivityWatch/aw-client-js#44 to accomplish ActivityWatch/activitywatch#991
Also fixed so that we don't fetch bucket events if vis_timeline is not in the Activity view. (big perf improvement, major decrease in requests!)
For now there will be some verbose logs to make it easy to debug if something is not working, but it can easily be removed in the future.
For now the cache is cleared on page reload.