Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeline - Date range - "Update" button issues #395

Closed
AlexanderMakarov opened this issue Jan 22, 2023 · 0 comments · Fixed by #610
Closed

Timeline - Date range - "Update" button issues #395

AlexanderMakarov opened this issue Jan 22, 2023 · 0 comments · Fixed by #610

Comments

@AlexanderMakarov
Copy link

AlexanderMakarov commented Jan 22, 2023 •
edited
Loading

In 0.12.1 version there are multiple issues with "Update" button on "Timeline" tab if use "Interval Mode = Date range". All issues are presented on video https://user-images.githubusercontent.com/2630978/213903761-d295b2f6-b95b-4896-aa8c-5fe36cefe94c.mp4

  1. UI sends a bunch of requests with "start = start_date" and "end=end_date" on one click.
  2. UI doesn't update interface if received 0 events.
  3. If don't change start_date/end_date and press "Update" button then nothing happens in sense of back-end requests (imagine situation when user wants to update events on the timeline for "today" or after "Export Raw Events" operation).
  4. (optional and more like an improvement) UI doesn't react on "Update" button presses at all (imagine slow back-end when new events coming with decent delay or case when events on one day totally matches events for another day).

Due to I haven't recorded events on this machine for almost the whole month then it gets nothing for chosen (on video) dates. Actual state is below:
image

Machine is Linux Mint on 5.4.0-137-generic core, Firefox 109.0 (64-bit).
ideadapt added a commit to ideadapt/aw-webui that referenced this issue Sep 8, 2024
@ideadapt
notify user, that timeline was not updated / re-rendered on purpose (…
d15b9ef 
…because there are no matching events to render). addresses issues reported in ActivityWatch#395
@ideadapt ideadapt mentioned this issue Sep 8, 2024
Merged
ErikBjare added a commit that referenced this issue Oct 5, 2024
@ideadapt @ErikBjare
feat(ux): improve timeline usability (#610)
291da6f 
* require fewer clicks for time interval changes. apply bootstrap styles.

* notify user, that timeline was not updated / re-rendered on purpose (because there are no matching events to render). addresses issues reported in #395

* update lastUpdate timer display every 500ms

* use for loop to render duration buttons. replace sr-only by d-none.

* extra margin for small screens.

* re-add sync button next to last update label. always show it, and label it "reload" instead of former "update".

* Apply suggestions from code review

* tests: fixed e2e test for new timeline inputs

* fix: minor style improvements to new timeline

---------

Co-authored-by: Erik Bjäreholt <erik.bjareholt@gmail.com>
Co-authored-by: Erik Bjäreholt <erik@bjareho.lt>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve timeline usability (less clicks to apply time filters) ideadapt/aw-webui
1 participant
@AlexanderMakarov