-
-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Most visited URLs #99
Comments
This is working as expected in firefox on linux on transform-next. Once we get the appname of chrome and firefox on macOS and Windows and whitelist those in the filtering in the query this issue should be done. |
@johan-bjareholt Nice, what happens if the user doesn't use the browser watcher? Will some useful message be displayed? |
It gives you a dropdown to select browser bucket from, and if there is none available it should show "No browser bucket available" if I remember correctly but havn't tested. Will be easy to fix a more in-your-face notice though which we probably should fix later. |
@johan-bjareholt Alright, great! |
Fixed in the webui so it recognizes whether it's a chrome or firefox bucket and filters both appropriately when the window is focused on Linux. So the only thing needed now is the appnames of firefox+chrome on windows and macOS and then it should be working reliably. |
Woah, that's really nice!
…On Dec 22, 2017 21:03, "Johan Bjäreholt" ***@***.***> wrote:
Fixed in the webui so it recognizes whether it's a chrome or firefox
bucket and filters both appropriately when the window is focused on Linux.
So the only thing needed now is the appnames of firefox+chrome on windows
and macOS and then it should be working reliably.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#99 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABVxunFywssF8bTMdQNkhY_KnGCmO8Jdks5tC8vJgaJpZM4PBVUc>
.
|
Should hopefull work on all platforms now |
Doesn't seem to work for @exoji2e on macOS. Didn't have time to investigate further but he was running the latest commits. Will check with him again soon. |
It does work, the problem was that When I run
And starts running Oh wait, so .git is just a file:
A proposal would be to have two targets, one that does the recursive update and one that does not? |
Oh, didn't know the .git folder could be created as a symlink. Could be easily fixed by changing that line into |
@exoji2e Fixed, please try it now :) |
Great, it works for me :) |
Alright! Then I think we can close this as soon as we fix proper error/warn/info messages in the cases of:
|
Is this not already available? If you choose a day with a browser bucket without any data that specific day it will show "No Data"
Do you mean detect like "Hey I see that you are using Chrome, wanna install the AW extension?" or "I see that you had Chrome focused during this timeperiod but there is no activity in the browser bucket, something must've gone wrong"? |
@johan-bjareholt I'm not quite sure which of those I meant, but regardless it seems like a minor issue so lets just close this for now. Awesome work overall 🎉 |
Firefox-esr should be added on Linux aswell |
I'd like to add a most visited URLs/hostnames to the Activity view.
What needs to be done:
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
The text was updated successfully, but these errors were encountered: