Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running make build replaces aw-core from filesystem with latest git version #173

Closed
ErikBjare opened this issue Feb 20, 2018 · 2 comments
Closed

Comments

@ErikBjare
Copy link
Member

ErikBjare commented Feb 20, 2018

So I wanted to add a function to query2 but for whatever reason the old query2_functions.py file just kept getting installed and the symlinking done when DEV=true (pip3 --editable) didn't seem to work.

I discovered what happens is the following:

  1. aw-core gets installed, as it should
  2. aw-client gets installed, has aw-core as a dependency, uninstalls the "right" version of aw-core and installs the wrong version from git

The same probably happens with aw-server for both aw-client & aw-core. This issue is therefore likely to have far-reaching consequences for builds in CI and elsewhere.

This is due to the giving --upgrade to pip when installing (which, surprisingly, also happily does downgrades), removing the option is something I want to avoid if I can.

Options

  1. Simply don't install an older version from git if a newer version is already installed, but I don't know if this is possible in some easy way.
  2. Add a flag similar to DEV=true that enables the pip --upgrade flag.
  3. Install aw-client and aw-core last in the build process (this is ugly, but would probably work)
@ErikBjare ErikBjare changed the title Running make build overwrites with aw-core from git Running make build installs aw-core from git, not from filesystem Feb 20, 2018
@ErikBjare ErikBjare changed the title Running make build installs aw-core from git, not from filesystem Running make build replaces aw-core from filesystem with latest git version Feb 20, 2018
ErikBjare added a commit that referenced this issue Feb 20, 2018
@ErikBjare
Copy link
Member Author

ErikBjare commented Feb 20, 2018

Implemented option number 3 as a temporary (?) workaround in 53943e7.

@ErikBjare
Copy link
Member Author

This isn't really an issue after 53943e7, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant