You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So I wanted to add a function to query2 but for whatever reason the old query2_functions.py file just kept getting installed and the symlinking done when DEV=true (pip3 --editable) didn't seem to work.
I discovered what happens is the following:
aw-core gets installed, as it should
aw-client gets installed, has aw-core as a dependency, uninstalls the "right" version of aw-core and installs the wrong version from git
The same probably happens with aw-server for both aw-client & aw-core. This issue is therefore likely to have far-reaching consequences for builds in CI and elsewhere.
This is due to the giving --upgrade to pip when installing (which, surprisingly, also happily does downgrades), removing the option is something I want to avoid if I can.
Options
Simply don't install an older version from git if a newer version is already installed, but I don't know if this is possible in some easy way.
Add a flag similar to DEV=true that enables the pip --upgrade flag.
Install aw-client and aw-core last in the build process (this is ugly, but would probably work)
The text was updated successfully, but these errors were encountered:
ErikBjare
changed the title
Running make build overwrites with aw-core from git
Running make build installs aw-core from git, not from filesystem
Feb 20, 2018
ErikBjare
changed the title
Running make build installs aw-core from git, not from filesystem
Running make build replaces aw-core from filesystem with latest git version
Feb 20, 2018
So I wanted to add a function to query2 but for whatever reason the old
query2_functions.py
file just kept getting installed and the symlinking done whenDEV=true
(pip3 --editable
) didn't seem to work.I discovered what happens is the following:
The same probably happens with aw-server for both aw-client & aw-core. This issue is therefore likely to have far-reaching consequences for builds in CI and elsewhere.
This is due to the giving
--upgrade
to pip when installing (which, surprisingly, also happily does downgrades), removing the option is something I want to avoid if I can.Options
DEV=true
that enables the pip--upgrade
flag.The text was updated successfully, but these errors were encountered: