Add wildcard support on rez test command #1870
Conversation
|
Hi @Ni-g-3l, thanks for creating this PR. Before we can review and consider your changes, you will need to sign the CLA. See the comment above for details. Let us know if you have questions. |
Signed-off-by: Nig3l <nig3lpro@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1870 +/- ##
==========================================
+ Coverage 59.28% 59.31% +0.02%
==========================================
Files 126 126
Lines 17217 17223 +6
Branches 3017 3017
==========================================
+ Hits 10207 10215 +8
+ Misses 6325 6323 -2
Partials 685 685 ☔ View full report in Codecov by Sentry. |
|
Thanks, I triggered the CI. |
Signed-off-by: Nig3l <nig3lpro@gmail.com>
| @@ -206,6 +207,16 @@ def get_test_names(self, run_on=None): | |||
|
|
|||
| return self.get_package_test_names(package, run_on=run_on) | |||
|
|
|||
| def find_requested_test_names(self, requested_tests): | |||
There was a problem hiding this comment.
Umm, could we maybe add a new parameter to get_test_names? I'm not sure why we need a different method when get_test_names could have the ability to do all the filtering for us.
What do you think?
There was a problem hiding this comment.
I think it's better to separate fetch tests from packages and filter them on regex in order keep available to fetch tests without any filter, but I could be wrong and this case won't appear the future. As you want I can make the fix I you want
JeanChristopheMorinPerso
changed the title
Signed-off-by: Nig3l <nig3lpro@gmail.com>
Allow user to run multiple tests thanks wildcard
For example:
rez test testing_obj-1.0 command_as_*will runcommand_as_string_successand command_as_string_fail`rez test testing_obj-1.0 command_as_* check_car_ideaswill runcommand_as_string_success,command_as_string_fail' andcheck_car_idea`