-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom record extractors fail with indexes #614
Labels
bug
Something isn't working
Comments
yruslan
added a commit
that referenced
this issue
Apr 27, 2023
yruslan
added a commit
that referenced
this issue
Apr 28, 2023
yruslan
added a commit
that referenced
this issue
May 1, 2023
yruslan
added a commit
that referenced
this issue
May 3, 2023
yruslan
added a commit
that referenced
this issue
May 3, 2023
yruslan
added a commit
that referenced
this issue
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Under some conditions index offsets do not point to the location of record split when custom record extractors are used.
Expected behavior
Indexes should aways point to the beginning of a next record.
Context
So this is not really a bug. This happens when a custom record extractor uses the input stream in its constructor and the offset reported by it for the first record is not the same as the initial offset of the stream.
While a record extractor should not move the initial offset before the first
next()
is invoked, it could be nice if the index builder won't depend on this assumption.The text was updated successfully, but these errors were encountered: