Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code reusability for Grade regex #235

Merged
merged 2 commits into from
Nov 20, 2022

Conversation

HowSuen
Copy link

@HowSuen HowSuen commented Nov 20, 2022

No description provided.

@HowSuen HowSuen requested a review from darrtzj November 20, 2022 07:02
@HowSuen HowSuen self-assigned this Nov 20, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 68.90% // Head: 68.90% // No change to project coverage 👍

Coverage data is based on head (e876c85) compared to base (f1db547).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #235   +/-   ##
=========================================
  Coverage     68.90%   68.90%           
  Complexity      599      599           
=========================================
  Files            99       99           
  Lines          1962     1962           
  Branches        230      230           
=========================================
  Hits           1352     1352           
  Misses          512      512           
  Partials         98       98           
Impacted Files Coverage Δ
src/main/java/friday/model/grades/Grade.java 93.33% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@darrtzj darrtzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@darrtzj darrtzj merged commit fcdb825 into AY2223S1-CS2103T-W15-4:master Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants