Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final v1.4 fix #178

Merged
merged 3 commits into from
Nov 7, 2022
Merged

Final v1.4 fix #178

merged 3 commits into from
Nov 7, 2022

Conversation

hanwenlai
Copy link

  • Include essential logging at different parts of the code.

@hanwenlai hanwenlai added the enhancement New feature or request label Nov 7, 2022
@hanwenlai hanwenlai added this to the v1.4 milestone Nov 7, 2022
@hanwenlai hanwenlai self-assigned this Nov 7, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #178 (832b22f) into master (7908fa0) will increase coverage by 0.07%.
The diff coverage is 86.66%.

@@             Coverage Diff              @@
##             master     #178      +/-   ##
============================================
+ Coverage     75.27%   75.34%   +0.07%     
- Complexity      666      669       +3     
============================================
  Files           100      100              
  Lines          2022     2036      +14     
  Branches        241      241              
============================================
+ Hits           1522     1534      +12     
- Misses          408      410       +2     
  Partials         92       92
Impacted Files Coverage Δ
...in/java/seedu/address/logic/parser/ParserUtil.java 84.84% <60.00%> (-1.33%) ⬇️
...edu/address/logic/commands/ClearRecordCommand.java 100.00% <100.00%> (ø)
...java/seedu/address/logic/commands/ListCommand.java 100.00% <100.00%> (ø)
...eedu/address/logic/commands/ListRecordCommand.java 100.00% <100.00%> (ø)
...ain/java/seedu/address/model/person/Birthdate.java 84.61% <100.00%> (+2.00%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

EiffelLKF
EiffelLKF approved these changes Nov 7, 2022
View reviewed changes
Copy link

@EiffelLKF EiffelLKF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EiffelLKF EiffelLKF merged commit 08ae0bd into AY2223S1-CS2103T-T14-3:master Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EiffelLKF EiffelLKF EiffelLKF approved these changes

@marclzh marclzh Awaiting requested review from marclzh

@anthonyhoth anthonyhoth Awaiting requested review from anthonyhoth

@LJXSean LJXSean Awaiting requested review from LJXSean

Assignees

@hanwenlai hanwenlai

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@hanwenlai @codecov-commenter @EiffelLKF