allow usage of latest pytorch_lighning #8508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladmandic
changed the title
|
did you forget to import warnings |
i did, i need to be more carefull when creating per-pr branches from my main. |
|
Does this just disable all deprecation warnings from all sources? |
i just made it module specific, but i don't think it makes a big difference as webui disables all warnings by default. (pytorch_lightning requires additional handling because it re-enables them in its init code). |
kbakdev
approved these changes
Mar 15, 2023
AUTOMATIC1111
approved these changes
Mar 25, 2023
brkirch
pushed a commit
to brkirch/stable-diffusion-webui
that referenced
this pull request
Apr 5, 2023
allow usage of latest pytorch_lighning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is optional PR for people that want to use newer version of
pytorch_lightning.there are number of PRs that tried to update it from 1.7.6 to 1.7.7, but this PR allows usage all the way to newest 1.9.4.
basically, new package is fully compatible except for a future deprecation warning (will be in effect in version 2.0).
to fully address deprecation warning would require changes to imports in several upstream libs as well, so easiest (and safe) for now is to ignore it.