-
Notifications
You must be signed in to change notification settings - Fork 27.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block event propagation when lightbox is triggered #616
Conversation
yeah that's great |
I checked out 23a0ec0, and it seems that when you click on image in gallery you still get to view the next one, not the one you clicked. When using Firefox, that is - Chrome does work. |
I'll get it installed and take a look. |
Thank you so much!! Is there a donations box for this project? It's awesome! :) |
@AUTOMATIC1111 the Firefox issue will require some rework as the event order is seemingly running differently, possibly unlinking the standard events and wiring up new ones, which seems pretty invasive. |
maybe just a dirty workaround, but the fix could be as easy as: don't think you need to rewrite the whole engine for a click that triggers twice. |
…processor Revert "add back preprocessor in api"
Prevents incorrect switching to the next image when a preview is first clicked for full screen display in the lightbox.
Also adds previous and next arrows and right+left keyboard shortcuts.