Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block event propagation when lightbox is triggered #616

Merged
merged 4 commits into from
Sep 17, 2022
Merged

Block event propagation when lightbox is triggered #616

merged 4 commits into from
Sep 17, 2022

Conversation

dfaker
Copy link
Collaborator

@dfaker dfaker commented Sep 17, 2022

Prevents incorrect switching to the next image when a preview is first clicked for full screen display in the lightbox.

Also adds previous and next arrows and right+left keyboard shortcuts.

image

@AUTOMATIC1111
Copy link
Owner

yeah that's great

@AUTOMATIC1111 AUTOMATIC1111 merged commit 23a0ec0 into AUTOMATIC1111:master Sep 17, 2022
@AUTOMATIC1111
Copy link
Owner

AUTOMATIC1111 commented Sep 18, 2022

I checked out 23a0ec0, and it seems that when you click on image in gallery you still get to view the next one, not the one you clicked. When using Firefox, that is - Chrome does work.

@dfaker
Copy link
Collaborator Author

dfaker commented Sep 18, 2022

I checked out 23a0ec0, and it seems that when you click on image in gallery you still get to view the next one, not the one you clicked. When using Firefox, that is - Chrome does work.

I'll get it installed and take a look.

@GalaxyTimeMachine
Copy link

Thank you so much!! Is there a donations box for this project? It's awesome! :)

@dfaker
Copy link
Collaborator Author

dfaker commented Sep 19, 2022

@AUTOMATIC1111 the Firefox issue will require some rework as the event order is seemingly running differently, possibly unlinking the standard events and wiring up new ones, which seems pretty invasive.

@OWKenobi
Copy link
Contributor

maybe just a dirty workaround, but the fix could be as easy as:
"if firefox than scroll picture -1 after enlarge"
or, a bit more clean
"if firefox than ignore click events for 0,2 seconds after enlarge"

don't think you need to rewrite the whole engine for a click that triggers twice.

nne998 pushed a commit to fjteam/stable-diffusion-webui that referenced this pull request Sep 26, 2023
…processor

Revert "add back preprocessor in api"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants