Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REALTEK_RTL8195AM binary timestamp #9658

Merged
merged 1 commit into from
Feb 12, 2019
Merged

REALTEK_RTL8195AM binary timestamp #9658

merged 1 commit into from
Feb 12, 2019

Conversation

alekla01
Copy link
Contributor

@alekla01 alekla01 commented Feb 11, 2019 •
edited
Loading

MBEDOSTEST-458

Description

what: REALTEK_RTL8195AM test binary hash depends on build timestamp.
reason: https://github.com/ARMmbed/mbed-os/blob/master/tools/targets/REALTEK_RTL8195AM.py#L150
why does this matter: CI greentea-test skips binaries which have already passed. REALTEK_RTL8195AM test binary hashes are always different, which means CI cannot identify which binaries have already passed and which have not, thus all binaries for REALTEK_RTL8195AM are tested for (almost) every pull request for no reason.
solution: Keep binary hashes the same if dependencies have not been modified. Either remove the timestamp or enable timestamp redefining.

    build 1: •��IZ\    (�� J�mž !’ÑÊä¡…„	´q¿¦sÃ*�uÿMµ«U~LIÀFFFFFFFFFFFFFFFFøµ5*ÿÿÿ
    build 2: •���\\    (�� J�mž !’ÑÊä¡…„	´q¿¦sÃ*�uÿMµ«U~LIÀFFFFFFFFFFFFFFFFG.0øÿ

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ARMmbed/team-realtek

@ciarmcom ciarmcom requested review from a team February 11, 2019 12:00
@ciarmcom
Copy link
Member

@alekla01, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@ciarmcom
Copy link
Member

@alekla01, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

bridadan
bridadan approved these changes Feb 11, 2019
View reviewed changes
Copy link
Contributor

@bridadan bridadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me

@0xc0170 0xc0170 requested a review from a team February 11, 2019 15:56
@tung7970
Copy link
Contributor

Looks ok to me. If you can squash three commits into one, that will be easier to track.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 11, 2019

@alekla01

build 1: •��IZ\ (�� J�mž !’ÑÊä¡…„ ´q¿¦sÃ�uÿMµ«U~LIÀFFFFFFFFFFFFFFFFøµ5ÿÿÿ
build 2: •���\ (�� J�mž !’ÑÊä¡…„ ´q¿¦sÃ*�uÿMµ«U~LIÀFFFFFFFFFFFFFFFFG.0øÿ

What is this ? I can't read it..

@cmonr
Copy link
Contributor

cmonr commented Feb 11, 2019

@alekla01 Doesn't this run the risk of not running tests when they need to?
How often is DAPLINK_TIMESTAMP updated?

@alekla01
Copy link
Contributor Author

@0xc0170
What is this? *.bin diff.

@cmonr
Doesn't this run the risk of not running tests when they need to? No.
How often is `DAPLINK_TIMESTAMP` updated? It's not.

@cmonr
Copy link
Contributor

cmonr commented Feb 12, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 12, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 26751ee into ARMmbed:master Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bridadan bridadan bridadan approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@alekla01 @ciarmcom @tung7970 @0xc0170 @cmonr @mbed-ci @bridadan