FUTURE_SEQUANA: SPI HAL fixes #9647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Removed random i/o glitches occurring during device reconfiguration 2. Fixed hazardous reads occurring at the end of transfer resulting in incorrect values being received 3. Added spi_free() function 4. Replaced default M0 image with a one ignoring i/o reservation. This is a workaround for missing proper destructors in Mbed drivers and BlockDevice tests failing on repeated initialization Fixes issue ARMmbed#9620.
|
@lrusinowicz, thank you for your changes. |
orenc17
approved these changes
Feb 10, 2019
There was a problem hiding this comment.
I can confirm that this fixes the issue
run sd-example successfully on FUTURE_SEQUANA and FUTURE_SEQUANA_PSA
@lrusinowicz could you also generate new PSA images
0xc0170
approved these changes
Feb 11, 2019
|
Ci started |
|
@orenc17 This fix doesn't really affect M0 PSA image, which doesn't use SPI. I'm going to submit the fix for PSA deep sleep tests and then will re-generate M0 PSA images with both fixes. |
Test run: SUCCESSSummary: 12 of 12 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in incorrect values being received
a workaround for missing proper destructors in Mbed drivers and BlockDevice
tests failing on repeated initialization
Fixes issue FUTURE_SEQUANA: failing to pass block device tests. #9620.
Test log:
tests_sd_sequana_gcc_20190208.log
Additionally deleted obsolete psoc63_m0_ble_controller_1.01.hex image file.
Description
Pull request type
Reviewers