-
Notifications
You must be signed in to change notification settings - Fork 10.4k
AFNetworking 2.0 - Fix empty content crash on AFHTTPSessionManager.post #4296
AFNetworking 2.0 - Fix empty content crash on AFHTTPSessionManager.post #4296
Conversation
If you are consuming the AFHTTPSessionManager from swift on xcode 9.3 or above, this will crash when the response has no content (204). This is because of strict closure signature in swift.
If you are consuming the AFHTTPSessionManager from swift on xcode 9.3 or above, this will crash when the response has no content (204). This is because of strict closure signature in swift.
@SlaunchaMan this pull request fixes #4176 . |
Thanks for the PR! I’ll have to make a quick update to the |
Hi, has there been any update on this. Thanks |
Hi - has there been any movement on this? Running into the exact same problem. Thanks so much! |
To follow up real quick, I think to fix this entirely it might be necessary to add a bunch more Thanks for exploring this, though - at the very least I now have a fork that I can use for the meantime! |
@jcravioto Sorry for taking so long on this; for this to get merged and released, we need to get #4329 building successfully on Travis. It seems close, but failing for weird reasons. If you have some spare time to try to help fix it, we can get this out there. @sashaweiss If we can get the above done, would you mind submitting a PR with your changes to add more nullability annotations? |
And of course another option would be to upgrade to AFNetworking 3.x. :) |
Ugh I'd love to @SlaunchaMan...dependencies beyond my control unfortunately. I'd be happy to open a PR with more nullability! I'll stay tuned here, and look into it hopefully soon. |
Hey @SlaunchaMan - opened a PR adding Thanks again for your help! |
Hey all, just wanted to check in post-holidays and see if there had been any movement on this, or if I could lend a hand? Thanks so much! |
Can you merge in the latest changes from the |
If you are consuming the AFHTTPSessionManager from swift on xcode 9.3 or above, this will crash when the response has no content (204). This is because of strict closure signature in swift.