Hoping this will fly with you guys ;)

With these new features, we can do this:

AFImageDownloader with only disk NSURLCache

    // Force AFNetworking to NOT use any RAM whatsoever for image downloading
    // (neither backed by NSURLCache nor imageCache). We will solely rely on
    // NSURLCache backed by disk
    // (i.e. won't use AFAutoPurgingImageCache and NSURLCache.memoryCapacity=0 disk=300)
    NSURLCache* imageDownloaderCache = [[NSURLCache alloc] initWithMemoryCapacity:0
                                                                     diskCapacity:300 * 1024 * 1024
                                                                         diskPath:@"com.alamofire.imagedownloader"];
    
    NSURLSessionConfiguration* imageDownloaderSessionConfiguration = [AFImageDownloader defaultURLSessionConfiguration];
    imageDownloaderSessionConfiguration.URLCache = imageDownloaderCache;
    AFImageDownloader* imageDownloader = [[AFImageDownloader alloc] initWithSessionConfiguration:imageDownloaderSessionConfiguration];
    imageDownloader.imageCache = nil;
    // If in the future, we wanted to cache thumbnails in RAM, our own P2AFAutoPurgingImageCache shall do the trick
//    imageDownloader.imageCache = [[P2AFAutoPurgingImageCache alloc] initWithMemoryCapacity:5 * 1024 * 1024
//                                                                   preferredMemoryCapacity:4 * 1024 * 1024];
    [UIImageView setSharedImageDownloader:imageDownloader];

Optional P2AFAutoPurgingImageCache that only caches thumbnails

@interface P2AFAutoPurgingImageCache : AFAutoPurgingImageCache
@end

@implementation P2AFAutoPurgingImageCache

-(BOOL)shouldCacheImage:(UIImage *)image forRequest:(NSURLRequest *)request withAdditionalIdentifier:(NSString *)identifier
{
    // Only cache thumbnails
    return image.size.width <= 200 && image.size.height <= 200;
}

@end

Codecov Report

Merging #4010 into master will increase coverage by 0.25%.
The diff coverage is 97.11%.

@@            Coverage Diff             @@
##           master    #4010      +/-   ##
==========================================
+ Coverage   82.52%   82.77%   +0.25%     
==========================================
  Files          45       45              
  Lines        5270     5371     +101     
  Branches      439      442       +3     
==========================================
+ Hits         4349     4446      +97     
- Misses        682      685       +3     
- Partials      239      240       +1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd59ffa...9b33c16. Read the comment docs.

Candidate resolution for AFNetworking/issues/4008 and See AFNetworking/issues/4009

Hello @SlaunchaMan, @TheDom, it seems you were the last people to PR.

Could you help getting this PR reviewed (and hopefully accepted)?

Also, there hasn't been any release since March last year. Are there any plans for a new 3.1.x release?

🎉🎉🎉🎉🎉

I suppose you'll do the merge, @hemangshah?

Fixes #4035

@wjehenddher I don’t see the withAdditionalIdentifier: parameter being used anywhere in here. Where is this designed to be used? Can you add some tests around its expected behavior?

Fixes #4008

HI @SlaunchaMan

About #4010 (comment)

I'm being consistent with the other methods: the param identifier is declared in

- (BOOL)shouldCacheImage:(UIImage *)image forRequest:(NSURLRequest *)request withAdditionalIdentifier:(nullable NSString *)identifier;

within AFAutoPurgingImageCache.h

https://github.com/WJE/AFNetworking/blob/9b33c1699f3f94135fbc35cb06080cbfe9cf11d1/UIKit%2BAFNetworking/AFAutoPurgingImageCache.h#L84

The test case is here: It's a mock that returns YES or NO based on an initial configuration.

https://github.com/WJE/AFNetworking/blob/9b33c1699f3f94135fbc35cb06080cbfe9cf11d1/Tests/Tests/AFImageDownloaderTests.m#L562

https://github.com/WJE/AFNetworking/blob/9b33c1699f3f94135fbc35cb06080cbfe9cf11d1/Tests/Tests/AFImageDownloaderTests.m#L246

Makes sense?

🎉🎉🎉🎉🎉

Thank you @SlaunchaMan

Do you folks have ETA for new AFN 3.x release?

Hopefully very soon!

Before this I was using this piece of code

[weakImgV setImageWithURLRequest:request placeholderImage:placeholder usingActivityIndicatorStyle:UIActivityIndicatorViewStyleWhiteLarge success:^(NSURLRequest * _Nonnull request, NSHTTPURLResponse * _Nullable response, UIImage * _Nonnull image) {
            if (response && image) {
                [UIView transitionWithView:weakImgV
                                  duration:0.5f
                                   options:UIViewAnimationOptionTransitionCrossDissolve
                                animations:^{weakImgV.image = image;}
                                completion:nil];
                [weakImgV setImage:image];
                
            }
            else
            if (image) {
                [weakImgV setImage:image];
            }else {
                [weakImgV setImage:placeholder];
            }
            
        } failure:^(NSURLRequest * _Nonnull request, NSHTTPURLResponse * _Nullable response, NSError * _Nonnull error) {
            [weakImgV setImage:placeholder];
        }];
 

The only issue I'm getting with this is I always end up with animation on imageView. Previously I was checking if response is not null it means the image was downloaded from network then it's the first time image will be displayed and I add animation. Second execution will return cached image and at that time the response will be nil. So I am directly setting the image. After changing to Disk caching as suggested this isn't working anymore and I'm always getting the animation. Anyone knows how to fix this ?

AFImageDownloader

How we can get back the cached image after using your code ?